Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cxl-ui): cxl-course-card update styles when on large devices #416

Merged
merged 1 commit into from
May 30, 2024
Merged

feat(cxl-ui): cxl-course-card update styles when on large devices #416

merged 1 commit into from
May 30, 2024

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented May 24, 2024

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 76.12 KB (+0.08% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.99 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 140.5 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 258.65 KB (+0.03% 🔺)

@paulkirspuu
Copy link

With this patch, featured courses still look odd.

image

paulkirspuu
paulkirspuu requested changes May 27, 2024
View reviewed changes
Copy link

@paulkirspuu paulkirspuu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need featured course cards theme specified to course featured, and then font-size of that specific card adjusted.

cxl-card anywhere else don't need the $medium rule tbh, since font-size XL works everywhere else but featured.

@anoblet anoblet force-pushed the anoblet/feat/course branch 3 times, most recently from c122aa7 to e1b5e8e Compare May 30, 2024 14:13
@anoblet anoblet requested a review from paulkirspuu May 30, 2024 14:16
@paulkirspuu
Copy link

cxl-tabs-slider cxl-course-card[theme~=course]::part(name) rule --webkit-line-clamp gets overridden.

@paulkirspuu paulkirspuu merged commit 22f6225 into master May 30, 2024
5 checks passed
@pawelkmpt pawelkmpt deleted the anoblet/feat/course branch June 12, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulkirspuu paulkirspuu paulkirspuu approved these changes

@lkraav lkraav Awaiting requested review from lkraav

@pawelkmpt pawelkmpt Awaiting requested review from pawelkmpt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoblet @paulkirspuu